Fix Select button creation when there is no actions container

ixc / wagtail-instance-selector

A widget for Wagtail's admin that allows you to create and select related items

MIT License

54 stars 17 forks source link

Fix Select button creation when there is no actions container #8

Closed jeromelebleu closed 4 years ago

jeromelebleu commented 4 years ago

Issue Summary

If the user has no edit nor create permissions and inspect is disabled, the actions container will not be created. Thus, the Select button will not be added and it will not be possible to select an item out-of-the-box.

Proposed Changes

Create the actions container if it does not exist on the first td
Simplify selected object handling by using data-instance-selector-pk attribute on the Select button too

markfinger commented 4 years ago

Cool. Thanks for that 👍

markfinger commented 4 years ago

Simplify selected object handling by using data-instance-selector-pk attribute on the Select button too

Yeah, that's a much better approach 😄

markfinger commented 4 years ago

Thanks again, I've pushed 2.0.0 to PyPI.

jeromelebleu commented 4 years ago

You are welcome, thanks for this quick merge and release! :)