search

iximeow / yaxpeax-arch

fundamental traits to describe an architecture in the yaxpeax project
BSD Zero Clause License
11 stars 2 forks source link

Fix usage of `colors` flag without `use-serde` #4

Closed WINSDK closed 6 months ago

WINSDK commented 1 year ago

When compiling with just the colors flag, serde::Serialize was still being imported. This leads to compiler given an error about the missing dependency.

iximeow commented 6 months ago

sorry i missed this for so long, and thank you for the patch! i've actually just made this change + a few others for doc comments as well: https://github.com/iximeow/yaxpeax-arch/commit/e16faf58cc1e47e431bbf110bf9cda0047909630#diff-12d1cf56d5d03c679a5f8f1c48cfe969a5c4276a1bee8647cc548de13f18e465L139 .

i've also set up tests for the various feature combinations to guard against this kind of thing in the future. that's all released as yaxpeax-arch 0.2.8 now (which also now depends on the latest crossterm)