iximeow / yaxpeax-arch

fundamental traits to describe an architecture in the yaxpeax project
BSD Zero Clause License
11 stars 2 forks source link

Please update to crossterm 0.27.0 #6

Closed sylvestre closed 6 months ago

sylvestre commented 6 months ago

the current version is a bit old - makes it harder to package it

iximeow commented 6 months ago

oh it sure is. i'll have to take a look at if i've accidentally exported items from crossterm to find out if bumping crossterm a major or minor version change for yaxpeax-arch. there are a few crates from this vintage that have that... unfortunate wrinkle. if it would be a major bump i'll also be curious about what can be done in a minor bump kinda way..

crossterm itself is an optional dependency for a relatively unused feature in the crate, so i'd be curious if a slightly tweaked cargo stanza might let you drop the dependency too. (or if it's a used feature, i'm definitely interested in how the crate is used there.) i think there are a few ways to end up using yaxpeax-arch in a way that you'd end up packaging, is it through minidump-processor or something else?

iximeow commented 6 months ago

done! https://github.com/iximeow/yaxpeax-arch/commit/1e9cf24e4ceca8bfd48ff3e6f777fcec54b9a186, published as yaxpeax-arch 0.2.8.

sylvestre commented 6 months ago

Many thanks