iximeow / yaxpeax-x86

x86 decoders for the yaxpeax project
BSD Zero Clause License
129 stars 23 forks source link

Fails to build with yaxpeax-arch dep issue #1

Closed iankronquist closed 4 years ago

iankronquist commented 4 years ago
C:\Users\iakronqu\source>git clone https://github.com/iximeow/yaxpeax-x86.git
Cloning into 'yaxpeax-x86'...
...
C:\Users\iakronqu\source\yaxpeax-x86>cargo build
    Updating crates.io index
error: failed to load source for a dependency on `yaxpeax-arch`

Caused by:
  Unable to update C:\Users\iakronqu\yaxpeax-arch

Caused by:
  failed to read `C:\Users\iakronqu\yaxpeax-arch\Cargo.toml`

Caused by:
  The system cannot find the path specified. (os error 3)

Steps to repro:

  1. git clone from github
  2. cargo build
  3. cargo can't find yaxpeax-arch in the relative path.

Not sure if this is by design or a documentation bug but I figured I'd open an issue.

iximeow commented 4 years ago

it's a little of "by design" and a little of "documentation bug", sorry - until i have crates available, these dependencies happen to be laid out how i've been working on them. all yaxpeax-* decoders expect https://github.com/iximeow/yaxpeax-arch to be present at ../../yaxpeax-arch for the path dependency you're seeing at the moment.

you can either adjust Cargo.toml to have yaxpeax-arch = { git = "https://github.com/iximeow/yaxpeax-arch.git" }, or clone yaxpeax-arch as well. i have a few design questions to answer for yaxpeax-arch before putting it on crates.io, at which point i'll adjust dependencies to not involve where i happened to put repos :)

iankronquist commented 4 years ago

I figured as much but wanted to report it in case this was just an oversight. Neat project!

iximeow commented 4 years ago

oh right, yaxpeax-x86 and yaxpeax-arch are real crates that don't have weird path dependencies anymore. gonna close this since this should build off of crates.io without issue now.