Open iximeow opened 9 months ago
real_mode
, or whatever name it should be, should not have eip
probably... or should have an ip
. both? unsure.
eip
in either protected_mode
or real_mode
. i think this RegSpec
constructor and variant will get deleted.fn cs(&mut self)
and fn selects_cs(&self)
.
idle wishlist of things i'd like to break for a 2.0 version of the disassembler..
yaxpeax-x86
was one of the first crates i'd published and has some poor API choices as a result.{long,protected,real}_mode
need better namesx86_64
/x86_32
/x86_16
or... something, talking about the bit width of the instruction set.Operand
docs speak for themselves. whichRegSpec
is the base, or first register in the address? which is second? whichRegSpec
is the mask register inRegIndexBaseScaleDispMasked
? this would be a little more reasonable asRegIndexBase { base: RegSpec, index: RegSpec }
and so on. this will change in 2.0yaxpeax-arch
..