search

iximeow / yaxpeax-x86

x86 decoders for the yaxpeax project
BSD Zero Clause License
132 stars 23 forks source link

export `InstructionDisplayer` #9

Closed i509VCB closed 3 years ago

i509VCB commented 3 years ago

This makes generated docs refer to a type and show said type in the list of all structs rather than rustdoc showing gray text in return types.

i509VCB commented 3 years ago

Also, it isn't clear how I would send a patch to you over your own cgit server, would be nice if you could document where I could do so somewhere.

iximeow commented 3 years ago

oh! yes this definitely should be public, thank you for the PR. i imagine someone might want to write the type name too, it's rather rude of me to have a public function return an unnameable type.

yes, the difficulty of accepting patches for a repo hosted on cgit has been an issue. i'm happy to accept patches by email or github PR - i keep both repos in sync anyway. that deserves a note in the README or somewhere, too.

iximeow commented 3 years ago

(and now in the published docs as of 1.1.1)