Closed fsmiamoto closed 1 year ago
Great catch! I'll gladly merge it, but could you please reformat it a bit? The unsafe {}
blocks could be much smaller. Another minor ask - could you bump up the nix
package version on the way? 🙏
Sorry for the delay and thank you so much for the review! I'll work on the changes and will submit them shortly
No problem at all! Thanks for your time and effort!
Hi @iximiuz, sorry once again for the delay haha I've been really busy up until now but hopefully the changes are good now.
Merged! Amazing work! Thanks a lot for giving some love to shimmy! 🤗
As of 8226f532, build are failing locally with the report error below:
After fixing that, we get this:
This patch tries to fix those issues.
I'm a Rust n00b so probably there's a better way to do it but hey, at least I'm trying :sweat_smile: