search

ixixi / fluent-plugin-sqs

Store fluent-event as queue message to Amazon SQS.
35 stars 53 forks source link

Bump up fluentd dependency 0.12.x #17

Closed cosmo0920 closed 9 years ago

cosmo0920 commented 9 years ago

I'm not sure why this repository depends fluentd 0.10.x, but I bumped up fluentd dependency to 0.12.x.

Also I fixed test_helper to fix following errors:

     Failure/Error: Fluent::Test::InputTestDriver.new(Fluent::SQSInput).configure(config)
     NoMethodError:
       undefined method `event_router' for nil:NilClass
     # ./vendor/bundle/ruby/2.1.0/gems/fluentd-0.12.12/lib/fluent/test/base.rb:48:in `initialize'
     # ./vendor/bundle/ruby/2.1.0/gems/fluentd-0.12.12/lib/fluent/test/input_test.rb:28:in `initialize'
     # ./spec/lib/fluent/plugin/in_sqs_spec.rb:7:in `new'
     # ./spec/lib/fluent/plugin/in_sqs_spec.rb:7:in `block (2 levels) in <top (required)>'
     # ./spec/lib/fluent/plugin/in_sqs_spec.rb:9:in `block (2 levels) in <top (required)>'
     # ./spec/lib/fluent/plugin/in_sqs_spec.rb:48:in `block (4 levels) in <top (required)>'
     # ./spec/lib/fluent/plugin/in_sqs_spec.rb:49:in `block (4 levels) in <top (required)>'

NOTE: I confirmed this pull request with Ruby 2.1.6 without test-unit and 2.2.1 with test-unit 3.1.2. After add dependency for test-unit 3.0 or later PR is merged, also all tests will pass with Ruby 2.2.

And after this PR is merged, adding secret parameters PR feature will start to work!

ixixi commented 9 years ago

thanks for PR. released v1.6.0!

cosmo0920 commented 9 years ago

Thanks!