ixjf / MSIRGB

Alternative to MSI Mystic Light for controlling motherboard LEDs, without the fixed 7 colour limitation.
ISC License
398 stars 53 forks source link

After a (cold?) boot, I get random LED settings #163

Closed nsb-github closed 3 years ago

nsb-github commented 3 years ago

In the supported motherboard list, it mentions msi-b350 pro vdh. My issue is similar to the one mentioned here https://github.com/ixjf/MSIRGB/issues/113 The lua scripts run fine but the issue is with the color palette. Let say the color before setting a palette is 'x' (either white or the one set using running scripts). After applying any color palette say of color 'y', it starts flickering with 'y' on and off back to 'x' Currently I was using Pumpkin script. Then I applied a Green color palette. I maxed the 'Step Duration' to 511. Now I am getting around 3-4 sec of green then around 50 sec of orange-red color. What I wish is to set a single custom color.

ixjf commented 3 years ago

I'm assuming you fixed the problem. What was it?

nsb-github commented 3 years ago

For some reason I thought, there are 8 colors presets and anyone could to be selected at a time as what we have in any photo editing color select table. Later I realised, its always in 8-color transitioning mode. So to keep one color, all 8 must be of same color. This was further clear when I went through the scripts (based on my knowledge of C language).

It was stupid of me to miss that the app clearly states to define 8 colors to switch between. So, all works fine as I understood the functioning of the app.

Since I got your attention, could you clarify some things...

(1) why number 98 is used to normalize the Hue. All I understand is the Hue resets (to 0) every time 'i' increases to a multiple of 98.

(2) since a 16 step is used to scale the color intensity, I assumed 'f' is equivalent to 255 and each step is 255/16 units. In the hue wheel script, I even tried colour_step = 0.1 but still could see an instant change of color rather than a smooth transition. As far as I understand the colors are updated 0-255 in 16 steps no matter how low the color_step be. It being less than 1 just delay the color update. What could be done for a smooth transition? I am hoping if colors are updated at a higher step size, it would solve the issue. If nothing works, I also have thoughts on just to solder 0.1uF capacitors to RGB pins but only as a last resort as it will make the smooth effect permanent.

(3) Could we set min/max intensity in breathing mode? I mostly don't wish the effect to dark out completely.

(4) Is there a manual/guide available that lists all the functions that are used or could be used in the lua scripts for further customizations.

ixjf commented 3 years ago

1) This effect was ported from somewhere else, so I do not know the exact why, but it seems to me that it controls how fast you traverse the color palette (the higher the value, the smaller the step). The code should probably be cleaned up :)

2) Smoother transitions aren't really possible because each colour component is stored in a nibble (4 bits). You don't really get 0-255, but 0-15. This is a hardware limitation, nothing I can do :(

3) You can't change intensity of breathing mode either. Also a hardware limitation. It's not possible to change the brightness of the LEDs as far as I could tell.

4) Yes, there is: https://github.com/ixjf/MSIRGB/wiki

nsb-github commented 3 years ago

Just a thought/guess... I dont think it would be a hardware limitation as during breathing mode the leds are transitioning very smoothly and do not show "the staircase phenomena" with 16 steps. It seems more likely to be the firmware that is providing limited access to the API.

Anyway, this app is certainly miles better than the Mystic Light. Thank you very much.

ixjf commented 3 years ago

By "hardware limitation", I mean that the memory layout exposed by the chip does not allow one to define colours with greater accuracy.

ixjf commented 3 years ago

Do you need any help or can I close this issue?

nsb-github commented 3 years ago

I closed the article from my end. It shows " nsb-github closed this 12 days ago". Is it usual that every once and now, when I start the computer, the LED color profile/script is applied but with a flashing ON and OFF. When I open the app, the script is selected already. I have to manually select something else and reselect the previous one to stop the flashing. This does not happen every time I start the computer but only may be like every 2nd or 4th time.

ixjf commented 3 years ago

I closed the article from my end. It shows " nsb-github closed this 12 days ago".

You did, but then you reopened it.

Is it usual that every once and now, when I start the computer, the LED color profile/script is applied but with a flashing ON and OFF. When I open the app, the script is selected already. I have to manually select something else and reselect the previous one to stop the flashing. This does not happen every time I start the computer but only may be like every 2nd or 4th time.

It is not. Maybe another case of #116, #159. Can you try the workaround in #159 and see if this still happens?

ixjf commented 3 years ago

Hey, you can try the updated scripts (download the 'Scripts' folder individually, please, since I haven't released an update release for MSIRGB yet). Should fix the issue. If not, please reopen this issue.