When pressing "Apply" while a script is running, LED settings become broken (i.e. random)

ixjf / MSIRGB

Alternative to MSI Mystic Light for controlling motherboard LEDs, without the fixed 7 colour limitation.

ISC License

398 stars 53 forks source link

When pressing "Apply" while a script is running, LED settings become broken (i.e. random) #194

Closed ixjf closed 3 years ago

ixjf commented 3 years ago

Probably stopping the lighting module (MSIRGB.DLL) while it's applying settings, so it doesn't finish doing its thing?

ixjf commented 3 years ago

Can't replicate anymore. Likely same problem as when I changed between scripts and settings were mixed up. My guess was that because of SIO bank debug dumps taking a long time, the script service was forcing an abort while batch_commit was running, which led to some settings not being fully applied (happened when moving from, say, Police Lights to Pumpkin effect. Pumpkin does not batch calls, so one batch_commit call per change in LED settings).