search

ixkaito / frasco

Quick starter for Jekyll including full setup for Sass, PostCSS, Autoprefixer, stylelint, TypeScript, Webpack, ESLint, imagemin, Browsersync, etc.
https://ixkaito.github.io/frasco/
MIT License
131 stars 20 forks source link

Error withing gulpfile.js #23

Closed skydevht closed 6 years ago

skydevht commented 6 years ago

this

/**
 * Paths
 */
Object.keys(config.paths).forEach((key) => {
  if (key !== 'assets') {
    if (config.paths.assets === '') {
      paths[key] = `./${config.paths[key]}`;
    } else {
      paths[key] = `${config.paths.assets}/${config.paths[key]}`;
    }
  }
});

should be

/**
 * Paths
 */
Object.keys(config.paths).forEach((key) => {
  if (key !== 'assets' || key !== 'dest') {
    if (config.paths.assets === '') {
      paths[key] = `./${config.paths[key]}`;
    } else {
      paths[key] = `${config.paths.assets}/${config.paths[key]}`;
    }
  }
});

because of line 196

'!' + paths.dest + '/**/*',

which cause a reloading loop with browsersync

ixkaito commented 6 years ago

@Skyd1400 Thanks! Could you send a PR?