search

ixkaito / frasco

Quick starter for Jekyll including full setup for Sass, PostCSS, Autoprefixer, stylelint, TypeScript, Webpack, ESLint, imagemin, Browsersync, etc.
https://ixkaito.github.io/frasco/
MIT License
131 stars 20 forks source link

Fix gulp imagemin race conditions #36

Closed austinpray closed 3 years ago

austinpray commented 5 years ago

Without this you will run into a race condition where jekyll-build runs without images in the assets directory

ixkaito commented 5 years ago

@austinpray Thanks! Will merge.

MWDelaney commented 5 years ago

Any chance this could get merged? Thanks!

ixkaito commented 5 years ago

@austinpray @MWDelaney Sorry for the late reply. I have checked the PR carefully. I saw this PR will ignore the tasks configuration in frasco.config.js, and we won't be able to run the browsersync task without eslint, imagemin, sass, or webpack when we run npm run browsersync.

austinpray commented 5 years ago

Oh I guess I clobber that functionality here: https://github.com/ixkaito/frasco/pull/36/files#diff-b9e12334e9eafd8341a6107dd98510c9L21

Probably won't revisit this, I don't use this project.

ixkaito commented 3 years ago

Released v1.0.0 and removed gulp. Now Frasco uses npm-scripts to run tasks.