search

ixmaps / website2017

Website for the IXmaps project
https://www.ixmaps.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

build / pre-compile creating unwanted files #33

Closed colinmccann closed 7 years ago

colinmccann commented 7 years ago

Something in the build process seems to re-gen this file: _assets/img/transparency/DataPrivacyTransparencyofCanadianISPs-2013.pdf

I can keep deleting it, but obviously that's not optimal. Anyone with more competency know why this is going on?

dcwalk commented 7 years ago

This should be addressed here: https://github.com/ixmaps/website2017/commit/1c37f1b1dcf7f601a94408daaf36f4b7aeafc55c

Basically during grunt build it monitors the img directory for changes and updates from __src, (https://github.com/ixmaps/website2017/blob/master/_assets/__build/Gruntfile.js)

Please test!

colinmccann commented 7 years ago

Makes sense. Can you explain to me the intended flow here? I'm making changes directly to eg the _assets/img directory (eg adding a file). Is it preferred to make changes in __src and let the build update as required?

dcwalk commented 7 years ago

Um, yeah I think you want to continue to take advantage of grunt watching/compiling scss/optimizing img sizes/serving php for testing changes locally and building. It should be documented maybe more clearly that you are expecting people to use that process (and my descriptive text in the README is maybe misleading.

So: those things watched should go to __src first (including images)

colinmccann commented 7 years ago

K, makes sense.

Was talking to Anto today, I think neither of us are fully clear on the expectations here (for example, he wants to run his own server, not the phpwatch one...). It seems that you understand this best - could you maybe update the README to include instructions on exactly how src/build/assets interact, what grunt processes are required, what the flow eg of adding a JS file would look like, etc.?

In the mean time, I'll move my new assets to __src...

On Wed, Feb 22, 2017 at 9:06 PM, dcwalk notifications@github.com wrote:

Um, yeah I think you want to continue to take advantage of grunt watching/compiling scss/optimizing img sizes/serving php for testing changes locally and building. It should be documented maybe more clearly that you are expecting people to use that process (and my descriptive text in the README is maybe misleading.

So: those things watched should go to __src first (including images)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ixmaps/website2017/issues/33#issuecomment-281678146, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEmO_DbK7zHzN5Og-PhNa7OPIQiihVks5rfEDRgaJpZM4MF66Q .

-- Colin

dcwalk commented 7 years ago

Answered on separate email thread. I think some confirmation on from @jknee on what expectations were could help guide our process?

dcwalk commented 7 years ago

Closing this as it was addressed in #40 and also #41, which both have landed. how about we open up new issues if/as the issues recurs?