search

ixmaps / website2017

Website for the IXmaps project
https://www.ixmaps.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

Redirect "/transparency" to most current transparency report #5

Closed dcwalk closed 7 years ago

dcwalk commented 7 years ago

My sense is this might be best handled via apache?

colinmccann commented 7 years ago

Huh, doing it with Apache is interesting.

But adding to this, there are a tonne of references to https://www.ixmaps.ca/transparency.php (and eg https://www.ixmaps.ca/transparency.php#fn8-inline) scattered throughout the code - needs cleanup at some point

dcwalk commented 7 years ago

I don't see https://www.ixmaps.ca/transparency.php in the code right now (link), I think you caught them? 🎉

colinmccann commented 7 years ago

I think I got them all - but that's a temp fix, since we should still deal with the core issue of 'redirect to most recent year'

colinmccann commented 7 years ago

Thinking about this more, I think we should just let it be - no need to get too cute. Just manual update with find/replace every couple of years. Not pretty, but uncomplex. Thoughts?

dcwalk commented 7 years ago

Your call, but it seems valuable to have people click "transparency" and have the browser bar reflect that with "transparency" shown vs. transparency-201X. Also, when updating with a new report you will have to change one place rather than multiple, which reduces the chances of missing a bit.

Andrew-Clement commented 7 years ago

Yes, I lean to Dawn on this. Minimizing the number of things to change annually will be safer.

colinmccann commented 7 years ago

Ok, fair - let's keep this open at a lower priority

colinmccann commented 7 years ago

Ok, I have addressed this. transparency.php will show the most recent report. See commit b5dba56508ed5807887ac11cadb3a74ddebcd616