search

ixmaps / website2017

Website for the IXmaps project
https://www.ixmaps.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

MAP Basic search - NSA search not working properly #65

Closed Andrew-Clement closed 7 years ago

Andrew-Clement commented 7 years ago

David Christopher is planning another eblast for Tuesday's big launch of the IXmaps tool, which includes

For example, you can search all routes between Vancouver and Toronto to see how many travel via the U.S. : https://docs.google.com/document/d/1ELM9lSbqbwB7_Jwc5GUiS4o7poISI8gQar-zbhnYAiw/edit#

However, he reports it doesn't work.

I checked it out using the action buttons and get a different, but still erroneous result.

It appears that logic is faulty, with the ORs not properly nested.

Since all Basic search options except the NSA one involve only ANDs, a quick fix would be to do the NSA condition first and then apply to others. pastedgraphic-1

agamba commented 7 years ago

As suggested, the way to construct this query in both the old (Explore) and new (Map) page is to add all the OR query statements first and then the AND ones

colinmccann commented 7 years ago

I mentioned this very thing in my email a week ago titled 'bug in search - OR condition'

I believe the correct approach here is to implement this correctly on the backend, instead of it being implicit (ie OR conditions first). However, in the interests of expediency, I can rewrite the bandaid fix for NSA to do the OR conditions first... pretty yucky tho

On Fri, Mar 24, 2017 at 9:51 AM, Antonio Gamba-Bari < notifications@github.com> wrote:

As suggested, the way to construct this query in both the old (Explore) and new (Map) page is to add all the OR query statements first and then the AND ones

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ixmaps/website2017/issues/65#issuecomment-288919301, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEmN2y4Cz0Sa4P2ddVkA7adGJ78XpGks5roy-6gaJpZM4Mnk3D .

-- Colin

colinmccann commented 7 years ago

Ok, I have put a bandaid on the bandaid. Basic Search now looks at OR conditions first. NSA should work. Strongly suggest that, if the backend cares about criteria order then it should be the one that reorders the conditions

Andrew-Clement commented 7 years ago

I still see the first AND with Vancouver before the OR's (I cleared my cache)

On 2017-03-24, at 4:14 AM, colinmccann notifications@github.com wrote:

Ok, I have put a bandaid on the bandaid. Basic Search now looks at OR conditions first. NSA should work. Strongly suggest that, if the backend cares about criteria order then it should be the one that reorders the conditions

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Andrew-Clement commented 7 years ago

@colinmccann I still get wrong results for this search, so am reopening.

BTW, Bluffdale and Bridgetown can be remover from the list of cities search against because they are not sites of suspected splitter operations but rather sites of storage and network operations respectively. They can still appear on the map.

colinmccann commented 7 years ago

Yeah, I hadn't pulled to server - you should get correct results now.

Have removed Bluffdale and Bridgetown