search

ixmaps / website2017

Website for the IXmaps project
https://www.ixmaps.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

MAP Layers - Highlighting not working #70

Closed Andrew-Clement closed 7 years ago

Andrew-Clement commented 7 years ago

Toggling layers turns the icons off and on, but the highlighting doesn't change - NSA stays highlighted and all the others remain un-highlighted independent of their state.

Andrew-Clement commented 7 years ago

OK, good to see highlighting now sticks, but NSA lay should be ON by default.

Andrew-Clement commented 7 years ago

So Re-opened

colinmccann commented 7 years ago

The change I made was not built correctly by grunt (so it never ended up on the server). This is not the first time this has happened, and it makes me want to abandon our grunt build setup

Andrew-Clement commented 7 years ago

Still not quite working properly :-(

This is how the map appears on first entry. Clicking once on NSA button has no discernable effect. Clicking again brings the icons. pastedgraphic-20

Also, when clicking a highlighted layer button, while the icons disappear immediately, how about also simultaneously turning off the highlight?

agamba commented 7 years ago

I had fixed this in the past, but I see Colin has change the behaviour. See my comment added here.

https://github.com/ixmaps/website2017/blob/master/_assets/__src/js/layers.js#L22

Colin, advice on your idea for this. I think toggleLayer('nsa'); does not work as expected.

colinmccann commented 7 years ago

Arg, ok, I will re-address this

On Tue, Mar 28, 2017 at 12:15 AM, Andrew-Clement notifications@github.com wrote:

Still not quite working properly :-(

This is how the map appears on first entry. Clicking once on NSA button has no discernable effect. Clicking again brings the icons. [image: pastedgraphic-20] https://cloud.githubusercontent.com/assets/12848029/24368593/d6957296-12d5-11e7-8d18-f0de3a6af516.png

Also, when clicking a highlighted layer button, while the icons disappear immediately, how about also simultaneously turning off the highlight?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ixmaps/website2017/issues/70#issuecomment-289520915, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEmEGutyB158JcooUapKefAwJlezyGks5rp-7AgaJpZM4MpUOb .

-- Colin

colinmccann commented 7 years ago

K, I have addressed this in commit 17f80a1ba6d9eb6ca632b054a757f2f1ccd86078

Anto, I refactored the layers code to separate out a renderLayers concept, and then have a call to render layers in gmaps.js (around ~515)

On Tue, Mar 28, 2017 at 3:18 AM, Colin McCann colindmccann@gmail.com wrote:

Arg, ok, I will re-address this

On Tue, Mar 28, 2017 at 12:15 AM, Andrew-Clement <notifications@github.com

wrote:

Still not quite working properly :-(

This is how the map appears on first entry. Clicking once on NSA button has no discernable effect. Clicking again brings the icons. [image: pastedgraphic-20] https://cloud.githubusercontent.com/assets/12848029/24368593/d6957296-12d5-11e7-8d18-f0de3a6af516.png

Also, when clicking a highlighted layer button, while the icons disappear immediately, how about also simultaneously turning off the highlight?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ixmaps/website2017/issues/70#issuecomment-289520915, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEmEGutyB158JcooUapKefAwJlezyGks5rp-7AgaJpZM4MpUOb .

-- Colin

-- Colin