ixmaps / website2017

Website for the IXmaps project
https://www.ixmaps.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

MAP Quick button - boomerang Should work for all non-US countries, not just CA #72

Closed Andrew-Clement closed 7 years ago

Andrew-Clement commented 7 years ago

Currently this button only finds CA>US>CA boomerangs. It should be revised to find [home CC] > US > [home CC] to appeal to those in other countries

colinmccann commented 7 years ago

I have created a proposed solution (not yet pulled to server), which uses: if (user has been geolocated) then do a boomerang of userCountry->US->userCountry else do a boomerang of CA->US->CA (with toast alerting the user to this)

This is a bit of a kludgy solution, imo. We could instead disallow boomerangs quick search if we can't geolocate the user? But this runs the risk of alienating users that have location services turned off (could be many of them, given our audience).

Andrew-Clement commented 7 years ago

Yes, I like this. Not clear why you regard this as kludgy. This seems loike the right way to handle a situation when insufficient info is available. The toast can indicate that if the user doesn't want to go back through the entry modal, the equivalent search can be done through Basic search

colinmccann commented 7 years ago

K, I will make the change live.

The toast can indicate that if the user doesn't want to go back through the entry modal Not sure what you mean here - the entry modal is unrelated to this, I believe

On Mon, Apr 3, 2017 at 12:09 AM, Andrew-Clement notifications@github.com wrote:

Yes, I like this. Not clear why you regard this as kludgy. This seems loike the right way to handle a situation when insufficient info is available. The toast can indicate that if the user doesn't want to go back through the entry modal, the equivalent search can be done through Basic search

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ixmaps/website2017/issues/72#issuecomment-290999653, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEmAnLu7bIoxKpCJNyHFw5Beji1MBEks5rr9Y-gaJpZM4MpmuD .

-- Colin

colinmccann commented 7 years ago

Pulled, tested, closing