search

ixmaps / website2017

Website for the IXmaps project
https://www.ixmaps.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

can map routes before count is returned #74

Closed colinmccann closed 7 years ago

colinmccann commented 7 years ago

Make MAP ROUTES FOUND button unclickable until query counts returns?

agamba commented 7 years ago

This is not really a bug. This is the expected behaviour. Note that the MAP ROUTES FOUND button is actually clickable, but it is not highlighted in blue. This was Andrew's suggestion to 1) encourage users to contribute and 2) indicate that given the current selection criteria in the modal, no results will be return with the search query.

agamba commented 7 years ago

Perhaps Colin's option is a good idea. please advice.

Andrew-Clement commented 7 years ago

Yes, I like Colin's suggestion. Grey out and disable the MAP ROUTES FOUND button until routes have actually been found, then make it actionable and blue.

BUT now the modal is broken again !!?? See new issue

agamba commented 7 years ago

This should is fixed. closing it

Andrew-Clement commented 7 years ago

Doesn't appear working to me: pastedgraphic-33

The MAP ROUTES FOUND appears with the same formating as the Contribute button an the link is active. It should appear faded grey - ie the text not black but an intermediate grey, slightly lighter (or perhaps darker?) than the background grey

colinmccann commented 7 years ago

closed with 61c7e2c1cc38c6b0473bbae064004996de31fbf1

Andrew-Clement commented 7 years ago

Mousing over the MAP ROUTES FOUND button changes its colour and turns the cursor from arrow to pointing hand, indicating that it is a live link that should actually do something. WHen there are no routes to map, it should be further greyed and when moused over be entirely responsive IMHO

Andrew-Clement commented 7 years ago

Greys out, but still shown as a live (but does nothing) A minor issue

Andrew-Clement commented 7 years ago

No change in behaviour. Did miss something or closed because not worth the effort? If so, please indicate this.