search

ixmaps / website2017

Website for the IXmaps project
https://www.ixmaps.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

MAP entry modal, bugs returned?? #76

Closed Andrew-Clement closed 7 years ago

Andrew-Clement commented 7 years ago

Appears to find 1 route, when there shouldn't be any.

Changing CC doesn't stick. changed CA to AR but on reload reverted to CA pastedgraphic-26

Lost auto complete in Contrib filed

Possibly performance issue on my end??

Andrew-Clement commented 7 years ago

Also, appears checked conditions with zero are excluded from join pastedgraphic-27

In cases mentioned above where the actual result should be zero, but it reports one route found and the MAP ROUTES FOUND button is blue, clicking it gets the correct response pastedgraphic-28

agamba commented 7 years ago

This should be fixed now. Please re-test same case

agamba commented 7 years ago

Conditions with zero results are excluded by default. I think we need automatically un-check those boxes for those cases. OR, we leave it to the user? Please advice

agamba commented 7 years ago

removing criteria = zero from the calculation of total routes is MUST on the server side. just to let you know..

Andrew-Clement commented 7 years ago

Conditions with zero results are excluded by default. I think we need automatically un-check those boxes for those cases YES.automatically un-check Don't leave it to user as it is inconsistent with Number of routes found that meet all the above checked conditions

colinmccann commented 7 years ago

@Andrew-Clement can we close this?

Andrew-Clement commented 7 years ago

No, problem persists.

If no routes for a condition, box should be un-checked

On 2017-06-20, at 1:00 PM, colinmccann notifications@github.com wrote:

@Andrew-Clement can we close this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

colinmccann commented 7 years ago

I may be misunderstanding something here... this is what I see on my end. What else needs to be unchecked?

screen shot 2017-06-22 at 2 50 57 pm
Andrew-Clement commented 7 years ago

See the Mar 27 comment above.

The line with You appear to be near Rome gives 0 routes but the box is checked. Simply un-check the box if the results are 0

colinmccann commented 7 years ago

So I guess the uncheck issue relates only to the location fields? (and not eg ISP). This definitely makes it harder to test :/ either way, this is likely best handled by @agamba , I believe

colinmccann commented 7 years ago

Since I was curious, I dug into the code around this. This opening modal is very complex, however everything looks correct to me (in regards to unchecking). I did my best to test it by modifying variables to simulate that I was in a location with no routes, and it unchecked as intended. @Andrew-Clement , can you please reconfirm?

Andrew-Clement commented 7 years ago

Yes, it worked as intended on first entry, but if I recall, if on entry the inferred city produces a non-zero result, but one then corrects the location producing a zero result, the boz stays checked. Something like that. I can't reproduce this now since my currently inferred location in both Map entry and the Client (Blackburn UK), is not the one recorded with the TR (aarrghh) and hence found through the DB query, which produces a zero initial result. Convoluted, picky and only a minor edge case, so best drop for now.