search

ixmaps / website2017

Website for the IXmaps project
https://www.ixmaps.ca
GNU Affero General Public License v3.0
4 stars 2 forks source link

MAP Generic US locations no longer excluded #87

Closed Andrew-Clement closed 7 years ago

Andrew-Clement commented 7 years ago

The Exclude Generic locations Setting appears not to work any more, since Maxmind 'fixed' the US country location from the Kansas corn filed to the middle of a nearby lake.

pastedgraphic-4

pastedgraphic-3

colinmccann commented 7 years ago

Closed with 2562e8d7286f7a18f7df449805b7e6fc739d1d4e

Andrew-Clement commented 7 years ago

Tested for US generic location. Interestingly our data reveals both old and new generic coords For TR ID 723234 hop 2 37.751 -97.822 hop 6 38.0 -97.0 Good to see both removed

colinmccann commented 7 years ago

On Thu, Jun 22, 2017 at 12:27 AM, Andrew-Clement notifications@github.com wrote:

Tested for US generic location. Interestingly our data reveals both old and new generic coords

Not surprising. Our IP table uses the Maxmind coordinate at the time the IP is first added to the DB. New IPs would never have the old 38/-97. We could discuss changing all 38/-97s to the new coords...

-- Colin

Andrew-Clement commented 7 years ago

Fine as is, if we consistently filter out both versions when excluding generic locations.

Is it contemplated that we would do a full geo-location/correction of the DB at some point?

colinmccann commented 7 years ago

That has been floated... it's a rather important decision so we wanted to be very careful, which led to inaction :/

On Thu, Jun 22, 2017 at 4:39 PM, Andrew-Clement notifications@github.com wrote:

Fine as is, if we consistently filter out both versions when excluding generic locations.

Is it contemplated that we would do a full geo-location/correction of the DB at some point?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ixmaps/website2017/issues/87#issuecomment-310330058, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEmKEKjzgupmvcYLdwV8G-AS9xv4qsks5sGjZSgaJpZM4NGo9J .

-- Colin