Cleanup-Refactor - Githubissues

ixmilia / converters

MIT License

9 stars 6 forks source link

Cleanup-Refactor #8

Closed sampletext32 closed 4 years ago

sampletext32 commented 4 years ago

Unify naming
Do not call ToArray for layerNames it's only used for Select, no need to copy to array
Extract IsCloseTo to Double Extension use it conveniently and everwhere
Unify more naming
Make Rects a class Since it's passed all around, we don't need copies.
Rename lambda variables for an open-source project names should be appropriate
Rename DxfRect in ToPdf Converter

sampletext32 commented 4 years ago

Forgot a thing, will fix soon.

sampletext32 commented 4 years ago

Any review here?

brettfo commented 4 years ago

Apologies, this fell off my radar last week.

brettfo commented 4 years ago

The only change I made was to restore SplinePoint2 equality to be exact instead of using the IsCloseTo method. I'm OK with there being an equivalent IsCloseTo method for SplinePoint2, etc., but I'd like equality to measure exactly that.