search

ixoncloud / cert-manager-webhook-cloudns

A Cert-Manager DNS01 provider for the ClouDNS DNS provider.
Apache License 2.0
5 stars 11 forks source link

Feat 3/sub auth id support #8

Closed Tristan971 closed 1 year ago

Tristan971 commented 2 years ago

Hi, this adds support for sub-auth-id based authentication (see #3).

As far as I can tell this should be all necessary for both the binary and the helm chart modulo perhaps stylistic preferences.

Conformance tests pass here (2nd commit fixes mismatched paths between script and what go test expects)

--- PASS: TestRunsSuite (87.81s) --- PASS: TestRunsSuite/Conformance (84.53s) --- PASS: TestRunsSuite/Conformance/Basic (16.61s) --- PASS: TestRunsSuite/Conformance/Basic/PresentRecord (16.61s) --- PASS: TestRunsSuite/Conformance/Extended (67.92s) --- PASS: TestRunsSuite/Conformance/Extended/DeletingOneRecordRetainsOthers (67.92s) PASS ok github.com/ixoncloud/cert-manager-webhook-cloudns 87.835s

raqbit commented 1 year ago

Hey there,

Apologies for the *checks notes* year late reply to your contribution :sweat_smile:

Thank you for your contribution, merging.