search

ixrock / XTranslate

Easy translate text on web pages (chrome extension)
https://chrome.google.com/webstore/detail/xtranslate/gfgpkepllngchpmcippidfhmbhlljhoo
114 stars 27 forks source link

[bug] it brokes page layout: adds footer #90

Closed vitaly-zdanevich closed 7 months ago

vitaly-zdanevich commented 7 months ago

In many pages, for example try here scroll to the bottom https://www.ethswarm.org/jobs/browser-extension-developer image

ixrock commented 7 months ago

Works for me, browser: latest chrome

vitaly-zdanevich commented 7 months ago

Try in Firefox.

ixrock commented 7 months ago

Try in Firefox.

we don't support firefox officially..

vitaly-zdanevich commented 6 months ago

But you published in Mozilla store?

This issue will be solved if you add display: none when invisible, please.

ixrock commented 6 months ago

Yes, this is old version for manifest v2. Now it's totally outdated, but afaik mozilla don't support V3 fully. See also https://github.com/ixrock/XTranslate/issues/1

vitaly-zdanevich commented 4 months ago

Can I contribute a fix to the version that is currently published to Mozilla store?

ixrock commented 4 months ago

You can try. Make a PR to firefox branch and I'll re-upload it to mozilla store at some point.