search

ixti / redmine_tags

Redmine plugin, that adds issues tagging support
GNU General Public License v3.0
196 stars 119 forks source link

Fixes wrong logging of tags changes when bulk editing and rubocop update #189

Closed tayateo closed 6 years ago

tayateo commented 6 years ago

During bulk editing when you change anything else but tags - the history is nevertheless logged with message about tags changing. Examples:

  1. you have no tags, bulk edit e.g. priority, do not add tags - in history you see 'tags were deleted'

  2. you have same tags, bulk edit e.g. priority, do not change tags - in history you see 'tags were changed from foo, bar to foo, bar'

  3. Latest version of rubocop complained about outdated syntax in the .rubocop.yml

marius-balteanu commented 6 years ago

@mayenok, thank you for finding and fixing this issue. I've merged your PR into the branch fix/bulk_edit_journals (for now) and I've applied one more commit in order to save the new tags only when there are changes and to avoid the extra call to the new tags_differ? method.

Please let me know what do you think about my changes.

marius-balteanu commented 6 years ago

Also, I think that we should add a migration script to delete the wrong journal details (where prop_key = 'tag_list' AND old_value = value).

tayateo commented 6 years ago

Thank you for considering my request ) And by the way thanks for the plugin too! ) I think that your version looks cleaner, and works fine as far as I see. As for migration - it is a great idea, I've forgotten about logs that are already wrong