search

ixti / redmine_tags

Redmine plugin, that adds issues tagging support
GNU General Public License v3.0
196 stars 119 forks source link

Since Redmine 4.0 we need at least acts-as-taggable-on version 5 #218

Closed kepi closed 4 years ago

kepi commented 4 years ago

I hit same problem with recent Redmine as reported in #206

I believe that it is benefitial to merge this as more people will be upgrading (and since tags are not yet in core).

PowerKiKi commented 4 years ago

Travis is failing. I assume this is unrelated to this change. But still, would one of you have any idea why this would happen ?

kepi commented 4 years ago

It looks like Redmine error unrelated to the plugin (see https://www.redmine.org/issues/32223)

There are two possible approaches I can think of:

  1. use Gemfile from newer versions with fix and somehow patch it in travis.yml
  2. support only stable Redmine 4

I tried to add fix for option 2 as I only wanted to know if I'm on right track. Not sure if this is correct approach for you, it may be better to go with 1.

PowerKiKi commented 4 years ago

Supporting only stable version seems reasonable to me. Thank you for the PR !