search

ixti / sidekiq-throttled

Concurrency and rate-limit throttling for Sidekiq
MIT License
698 stars 75 forks source link

migration plan for sidekiq 7 #165

Closed skyeagle closed 9 months ago

skyeagle commented 9 months ago

Hi @ixti

Thank you for your excellent work on this gem!

What would be a migration plan to upgrade sidekiq from 6 to 7, taking into account that version 1.0.0 that got released recently, drops support for sidekiq 6.x? Should we update this gem to 1.0.0alpha first, which is still compatible?

Thank you!

ixti commented 9 months ago

I have dropped the 6.5 support only for cleanup purpose. Will add it back to the matrix, as code should be fully 6.5.x compatible

ixti commented 9 months ago

Released v1.0.1 that allows using sidekiq-throttled with sidekiq-6.5.x

ixti commented 9 months ago

Notice, though, that sidekiq-pauzer >= 4.0.0 (required for bringing back queues pausing feature) is compatible with Sidekiq-7.x only. So You can:

  1. upgrade to: 
    gem "sidekiq", "< 8"
gem "sidekiq-throttled", ">= 1"
  2. once you're ready for sidekiq 7.x (my recent upgrade in a production app proved there's no problems if you're not heavily using internals or Sidekiq.redis): 
    gem "sidekiq", "< 8"
gem "sidekiq-throttled", ">= 1"
gem "sidekiq-pauzer", ">= 4"
skyeagle commented 9 months ago

Excellent, thank you for the blazing-fast fix!