search

ixti / sidekiq-throttled

Concurrency and rate-limit throttling for Sidekiq
MIT License
698 stars 75 forks source link

Support Sidekiq Pro super_fetch #175

Closed mnovelo closed 7 months ago

mnovelo commented 7 months ago

Distilling the discussions in this issue and the work in this fork, this adds support for Sidekiq Pro's super_fetch for v1 of sidekiq-throttled and v7.x of Sidekiq Pro.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6294b2b) 98.94% compared to head (e60d61e) 97.47%. Report is 1 commits behind head on improve-composability-of-patches.

:exclamation: Current head e60d61e differs from pull request most recent head 59862d1. Consider uploading reports for the commit 59862d1 to get more accurate results

Files Patch % Lines
lib/sidekiq/throttled/patches/super_fetch.rb 64.70% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## improve-composability-of-patches #175 +/- ## ==================================================================== - Coverage 98.94% 97.47% -1.47% ==================================================================== Files 18 19 +1 Lines 378 396 +18 Branches 52 54 +2 ==================================================================== + Hits 374 386 +12 - Misses 4 10 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ixti commented 7 months ago

@mnovelo I've extracted Ruby-3.3 support into a separate PR: #176 to avoid scope creep in this one.

ixti commented 7 months ago

o_O I swear I was not closing this PR

ixti commented 7 months ago

Just merged the improve-composability-of-patches branch.

ixti commented 7 months ago

@mnovelo please rebase this PR on main branch.

ixti commented 7 months ago

GH does not allow me to even reopen this PR. O_o what the...

mnovelo commented 7 months ago

Weird! I re-opened against the main branch