search

ixti / sidekiq-throttled

Concurrency and rate-limit throttling for Sidekiq
MIT License
698 stars 75 forks source link

Fix spec_helper for Sidekiq Pro #181

Closed mnovelo closed 7 months ago

mnovelo commented 7 months ago

Not sure how this got dropped, but this line is needed to prevent the Sidekiq Pro specs from running in Sidekiq 6.5.

Also, .rspec-local isn't actually being respected, so updated guidance to mention .rspec

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b4027cc) 98.95% compared to head (0f1f021) 98.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ======================================= Coverage 98.95% 98.95% ======================================= Files 18 18 Lines 381 381 Branches 53 53 ======================================= Hits 377 377 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ixti commented 7 months ago

I'm also confused why .rspec-local is not respected. And my initial idea was to use config.filter_run_excluding but I was afraid of false exclusions when not expected... I have an alternative idea though on how to fix this.

mnovelo commented 7 months ago

Closing since a better approach is in https://github.com/ixti/sidekiq-throttled/pull/182