search

ixti / sidekiq-throttled

Concurrency and rate-limit throttling for Sidekiq
MIT License
698 stars 75 forks source link

ci: Refactor Sidekiq-Pro tests conditionals #182

Closed ixti closed 7 months ago

ixti commented 7 months ago

Kudos to @mnovelo and @gstokkink for catching this and coming with proposals on fixes.

Closes: https://github.com/ixti/sidekiq-throttled/pull/181 Related-To: https://github.com/ixti/sidekiq-throttled/pull/180

ixti commented 7 months ago

@mnovelo Apparently we care only about Bundler.settings[...] as it should check ENV itself. Please let me know if this approach will work as expected.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b4027cc) 98.95% compared to head (085e9bb) 98.95%.

:exclamation: Current head 085e9bb differs from pull request most recent head c0d58e1. Consider uploading reports for the commit c0d58e1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #182 +/- ## ======================================= Coverage 98.95% 98.95% ======================================= Files 18 18 Lines 381 381 Branches 53 53 ======================================= Hits 377 377 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.