search

ixti / sidekiq-throttled

Concurrency and rate-limit throttling for Sidekiq
MIT License
710 stars 76 forks source link

Sidekiq::Throttled::Web.enhance_queues_tab not working in sidekiq-pro V4.0.3 #48

Closed Blokh closed 5 years ago

Blokh commented 6 years ago

Greetings,

The enhance_queues_tab provides you the feature of pausing the queue. I've noticed the feature stopped working after I updated the sidekiq version. It's probably the pool's logic since it became concurrent. and the pause does not block it for some reason.

gemfile.lock changed from: sidekiq-pro (4.0.2) to: sidekiq-pro (4.0.3) concurrent-ruby (>= 1.0.5)

Thanks in advance, Daniel.

ixti commented 6 years ago

Hm. In fact queue pausing should not be affected by sidekiq-pro update, unless you use some fetch logic provided by sidekiq-pro iteself. If you do - you will need to override their fetcher to utilize queue filter:

Sidekiq::Throttled::QueuesPauser.instance.filter(queues)
ixti commented 6 years ago

I never seen sidekiq-pro source code so I can't actually help in this particular case. But I think it should be pretty trivial to achieve.

Blokh commented 6 years ago

Thank you for the quick response, will try this ASAP and will let you know if this helped.