search

ixti / sidekiq-throttled

Concurrency and rate-limit throttling for Sidekiq
MIT License
710 stars 76 forks source link

Skip Making a Request to Redis if Limit is 0 #60

Closed mstruve closed 5 years ago

mstruve commented 5 years ago

If the limit is 0 there is no point wasting time and resources to make a request to Redis since we know the job will not be run.

This is a small performance optimization that would be really useful for my company's use case and I thought it might also be helpful for others. Let me know what you think! Thanks!

mstruve commented 5 years ago

HI! Any chance we could get this merged soon?

ixti commented 5 years ago

Thanks for reminder! Done.

mstruve commented 5 years ago

Hi! Any plans to issue a new release soon with these changes?

ixti commented 5 years ago

Oh. Sorry about that. Will do that tomorrow.

ixti commented 5 years ago

Released 0.10.0

mstruve commented 5 years ago

Thank you! Any chance you might have forgotten to push it up to rubygems? I am not seeing it listed. Thanks!

ixti commented 5 years ago

Oh. Indeed. Sorry, push failed and I did not noticed that. Fixed now.