search

iyegoroff / react-native-image-filter-kit

Various image filters for iOS & Android
MIT License
320 stars 43 forks source link

Bolts conflict with Expo/React-native #12

Closed Benjamin-Willard closed 5 years ago

Benjamin-Willard commented 5 years ago

React Native with Expo/ExpoKit Expo: 32.0.0 ExpoKit: 32.0.7 React Native: SDK 32 / 0.59.1 React-Native Image Filter Kit: 0.3.4

Duplicate symbols because of Bolts already publically installed, it will work if I remove all references of Bolts, but I have to do this every time I do pod install.

duplicate symbol _warnBlockingOperationOnMainThread in: /Users/benwillard/Library/Developer/Xcode/DerivedData/socialdrip-bumkwadcqonpraczbjjnmkqdxctn/Build/Products/Debug-iphoneos/Bolts/libBolts.a(BFTask.o) /Users/benwillard/Library/Developer/Xcode/DerivedData/socialdrip-bumkwadcqonpraczbjjnmkqdxctn/Build/Products/Debug-iphoneos/RNImageFilterKit/libRNImageFilterKit.a(IFKTask.o) ld: 1 duplicate symbol for architecture arm64

iyegoroff commented 5 years ago

@Uniphix , try to rename all conflicting identifiers inside rnifk Bolts dependency and submit a PR to this repo. Something like "adding 'ifk_' prefix" would be ok.

Benjamin-Willard commented 5 years ago

@iyegoroff can you clarify what exactly you mean? I haven't done something like that before

iyegoroff commented 5 years ago

You need to rename (at least) this - https://github.com/iyegoroff/react-native-image-filter-kit/blob/7062d954d2a8e02fe41034392d53b88df68f7601/ios/Bolts/IFKTask.m#L19