search

iyegoroff / react-native-image-filter-kit

Various image filters for iOS & Android
MIT License
320 stars 42 forks source link

Switch from Bolts-ObjC to Promises #5

Open iyegoroff opened 5 years ago

iyegoroff commented 5 years ago

Currently this module uses Bolts-ObjC under the hood. This fact could be a no go for some users because of it's BSD + PATENTS style license. Google's Promises library seems like a good alternative to Bolts-ObjC.

However, this is not a big deal right now (December 19, 2018) because react-native itself still uses a BSD + PATENTS licensed version of Bolts-Android via Fresco dependency.

Related issues: https://github.com/BoltsFramework/Bolts-ObjC/issues/319 https://github.com/BoltsFramework/Bolts-Android/issues/151 https://github.com/facebook/fresco/issues/2257

Benjamin-Willard commented 5 years ago

Any idea when you will switch this? We currently have to remove BOLTS from the pod manually everytime we want to build which is annoying...

dkfl1995 commented 5 years ago

@Uniphix How do you removing BOLTS from the pod manually? Please can you explain the way to do this? Cause I have error 

duplicate symbol _warnBlockingOperationOnMainThread in:
    /Users/dkfl1995/Library/Developer/Xcode/DerivedData/Foodilog-acbpmnmzimcujhfhaibeegswoqou/Build/Products/Debug-iphonesimulator/Bolts/libBolts.a(BFTask.o)
    /Users/dkfl1995/Library/Developer/Xcode/DerivedData/Foodilog-acbpmnmzimcujhfhaibeegswoqou/Build/Products/Debug-iphonesimulator/RNImageFilterKit/libRNImageFilterKit.a(IFKTask.o)
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
iyegoroff commented 5 years ago

@dkfl1995, this should be fixed in v0.3.5. Probably you just need to clean your project in Xcode, to remove this error.