iyegoroff / react-native-image-filter-kit

Various image filters for iOS & Android
MIT License
320 stars 42 forks source link

Images get blurry on iPhones but the same code performs well on Android. #51

Closed nime-sha256 closed 4 years ago

nime-sha256 commented 4 years ago

mobile platform(s) - iOS react-native Version - 0.62.2 react-native-image-filter-kit - 0.7.3

<Grayscale style={{height:'100%', width:'100%'}} onFilteringError={ ({ nativeEvent }) => {console.log(nativeEvent)} } onExtractImage={({ nativeEvent }) => {setUrl(nativeEvent.uri);}} extractImageEnabled={true} image={ < Image source={{uri:route.params.newImage.path}} resizeMode="cover" style={styles.photo} /> } />

Feedback is much appreciated. Thanks in advance.

iyegoroff commented 4 years ago

This doesn't seem related to rnifk. Image can be blurry because of some simulator/devserver issues.

RaphaelHadjadj commented 3 years ago

I have the same issue even with a production build on iOS. How could we solve it ? Do you have any ideas ?

cmora commented 3 years ago

@iyegoroff I have the same issue. Looks like the issue is related to the resizeMode="cover". The issue its only happening on IOS and when you add the resizeMode to cover. Any ideas about this?

cmora commented 3 years ago

@RaphaelHadjadj @Tharuka-Nimesha I just realized that the issue is related to the cache and the resizeMode="cover". I just disabled the cache for the thumbnails images and looks like this is working now for the main image.

<SelectedFilterComponent
          onFilteringStart={onFilteringStart}
          onFilteringFinish={onFilteringFinish}
          onExtractImage={onExtractImage}
          extractImageEnabled={false}
          disableCache={disableCache}
          style={[StyleSheet.absoluteFillObject]}
          image={children}
        />