Closed MaxBlesch closed 1 year ago
Please use this occasion to also fix the function names. E.g., wohngeld_basis_hh
should be wohngeld_basis_m_hh
. Even though we do not have checks as for _hh
/ _tu
, we should strive to be consistent on any deviations from annual measures, also for internal and sort-of-internal variables.
@ChristianZimpelmann, can you please check this one, potentially assigning someone to do it? At least the naming is still wrong.
Will do. I assigned the priority-high
label. I think it would be a good idea to use those labels to indicate urgent issues.
This doesn't seem to be fixed, yet.
I am not sure why income and rent are calculated on the tax unit level in the first place. If I understand correctly, the tax unit should not be relevant here, but always the full household: https://www.wohngeld.org/haushaltsmitglieder.html
Unrelated household members do not count for Wohngeld, but if I am not mistaken they also don't count for other transfers.. so we shouldn't have them in the same hh_id
.
@MaxBlesch @Eric-Sommer @mjbloemer
Similar problems also exist for the calculation of Kinderzuschlag and Elterngeld where we use both tax-unit-wide and household-wide variables in an inconsistent way.
We need to do the following:
Still open? Anything here that is not in #379?
Thanks! This is indeed fixed by #418.
Current and desired situation
Wohngeld is calculated right now on individual level and then reduced to the household level. We should exploit this structure and reduce calculation to the household level initially. We need to account for multiple tax units in a household when doing so. See below for details in the old code.
Proposed implementation
Reduce calculation to the household level.
Considered alternatives