Remove some cruft and set up coverage statistics

hmgaudecker commented 4 years ago

A look at the coverage statistics reveals that:

Not surprisingly, release.py and setup.py have zero coverage: https://codecov.io/gh/iza-institute-of-labor-economics/gettsim. @tobiasraabe, is it possible to tell codecove.io to focus on the gettsim subfolder? Is there anything outside of that folder that we would want to know about?
In the gettsim folder, only auxiliary.py has some missing stuff: https://codecov.io/gh/iza-institute-of-labor-economics/gettsim/src/master/gettsim/auxiliary.py. @MaxBlesch @Eric-Sommer @mjbloemer:
- Can we just delete the uprate function?
- Can we delete the "adult_married" unit ?

MaxBlesch commented 4 years ago

If there is not a real reason to keep the uprate functio, I will open a PR and submit a suggestion to remove auxiliary.py.

Eric-Sommer commented 4 years ago

For now, we can put the uprating aside. In practice, it is pretty important if data year and policy year differ. But this can be easily re-implemented.

adult_married is now defined within the functions where it is needed and can also be discarded.

mjbloemer commented 4 years ago

I have the impression that every uprating of monetary variables of the input data set should be done on the data preparation side.

MaxBlesch commented 4 years ago

Removed auxiliary.py with #59

MaxBlesch commented 4 years ago

This can be closed?

hmgaudecker commented 4 years ago

Closed via #59 and #64

iza-institute-of-labor-economics / gettsim

Remove some cruft and set up coverage statistics #58