search

iza-institute-of-labor-economics / gettsim

The GErman Taxes and Transfers SIMulator
https://gettsim.readthedocs.io/
GNU Affero General Public License v3.0
56 stars 33 forks source link

ENH: Make DEFAULT_TARGETS dependent on the policy environment. #627

Open hmgaudecker opened 1 year ago

hmgaudecker commented 1 year ago

Is your feature request related to a problem?

DEFAULT_TARGETS currently includes items that are not present in all years, which should throw an error. See here

Describe the solution you would like to see

Make DEFAULT_TARGETS dependent on the policy date.

amageh commented 6 months ago

Hi! I think this is an excellent idea. I want to add another related issue I came across when using set_up_policy_environment recently (I think it makes sense to add this here instead of opening a new issue, sorry if it was already raised somewhere else):

Maybe it would be good idea to add a warning to the function for dates that GETTSIM doesn't support or does not support very well. This applies to dates very far in the past but especially more recent policy environments.

For instance, the most recent version of GETTSIM is from summer 2023 and it thus probably doesn't include parameters for 2024 yet. In my opinion it would make sense to issue a warning to users in these cases since I don't expect everyone will check for this themselves.