Adding Soli to Lohnsteuer test cases

[JakobWegmann]

What problem do you want to solve?

Adding Soli to the lohnsteuer test cases in GETTSIM, thereby closes #563.

The actual work has been done in gettsim-code-for-picking .

The PR also harmonizes the names of all lohnsteuer related things in GETSSIM to lohnst_m (instead of the sometimes used lohn_st_m).

Todo

• [x] Document PR in CHANGES.md.

[codecov[bot]]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% :tada:

Comparison is base (b9aaaf8) 90.70% compared to head (4110a65) 90.83%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #653 +/- ## ========================================== + Coverage 90.70% 90.83% +0.12% ========================================== Files 48 48 Lines 3119 3119 ========================================== + Hits 2829 2833 +4 + Misses 290 286 -4 ``` | [Files Changed](https://app.codecov.io/gh/iza-institute-of-labor-economics/gettsim/pull/653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iza-institute-of-labor-economics) | Coverage Δ | | |---|---|---| | [src/\_gettsim/config.py](https://app.codecov.io/gh/iza-institute-of-labor-economics/gettsim/pull/653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iza-institute-of-labor-economics#diff-c3JjL19nZXR0c2ltL2NvbmZpZy5weQ==) | `33.33% <ø> (ø)` | | | [src/\_gettsim/functions.py](https://app.codecov.io/gh/iza-institute-of-labor-economics/gettsim/pull/653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iza-institute-of-labor-economics#diff-c3JjL19nZXR0c2ltL2Z1bmN0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | | | [src/\_gettsim/taxes/lohnst.py](https://app.codecov.io/gh/iza-institute-of-labor-economics/gettsim/pull/653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iza-institute-of-labor-economics#diff-c3JjL19nZXR0c2ltL3RheGVzL2xvaG5zdC5weQ==) | `89.87% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/iza-institute-of-labor-economics/gettsim/pull/653/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iza-institute-of-labor-economics)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[JakobWegmann]

@hmgaudecker I'm a little confused about the naming convention right now. Should the files and variables be called lohnst or lohn_st?

I thought that the idea was to rename everything to lohnst. But soli is called soli_st and and income tax eink_st.

[hmgaudecker]

@hmgaudecker I'm a little confused about the naming convention right now. Should the files and variables be called lohnst or lohn_st?

I thought that the idea was to rename everything to lohnst. But soli is called soli_st and and income tax eink_st.

That is because of this part of GEP-01:

Abbreviations of words that form a part of these names are always followed by an underscore, unless it is the last word.

So there is no abbreviation in the middle of lohnst, whereas there is one in eink_st. We should change soli_st eventually, I believe. Thought back then that the _st would be good for signalling that it is in the realm of taxes, but at least I have changed mz mind. That'll be for another day, however.

[JakobWegmann]

That is because of this part of GEP-01:

Abbreviations of words that form a part of these names are always followed by an underscore, unless it is the last word.

So there is no abbreviation in the middle of lohnst, whereas there is one in eink_st.

Ahh, that makes sense!