Closed lars-reimann closed 5 months ago
Attention: Patch coverage is 78.26087%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 89.41%. Comparing base (
284bfb3
) to head (add6232
).
Files | Patch % | Lines |
---|---|---|
src/_gettsim/shared.py | 70.58% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think the most straightforward application is in function _unterhaltsvors_anspruch_pro_kind_m
. There, we need to replace _unterhaltsvorschuss_eink_above_income_threshold_fg
. Instead, we should have a bool based on the parent's (linked via p_id_kindergeld_empf
) return value of _unterhaltsvorschuss_eink_above_income_threshold
.
In Lars' terminology:
_unterhaltsvorschuss_eink_above_income_threshold
p_id
p_id_kindergeld_empf
I think the most straightforward application is in function _unterhaltsvors_anspruch_pro_kind_m. There, we need to replace _unterhaltsvorschuss_eink_above_income_threshold_fg. Instead, we should have a bool based on the parent's (linked via p_id_kindergeld_empf) return value of _unterhaltsvorschuss_eink_above_income_threshold.
Thanks, the demo is now included.
I'll look into updating the type hint check later.
Thanks, the demo is now included.
Thanks! I just adjusted the column name and removed the obsolete aggregation dict at the top of the file.
I'm happy with the implementation but I'll let @hmgaudecker approve.
What problem do you want to solve?
Closes #708
Add a
join_numpy
function to make target columns available at the source level.The function gets
It then maps each foreign key to the associated target. Primary keys must be unique and foreign keys must point to some primary key.
Todo
Closes #XXXX
in the first PR comment to auto-close the relevant issue once the PR is accepted. This is not applicable if there is no corresponding issue.