iza-institute-of-labor-economics / gettsim

The GErman Taxes and Transfers SIMulator
https://gettsim.readthedocs.io/
GNU Affero General Public License v3.0
54 stars 32 forks source link

Several small fixes related to groupings #725

Closed ChristianZimpelmann closed 4 months ago

ChristianZimpelmann commented 5 months ago

What problem do you want to solve?

Closes #745

Several small fixes related to groupings.

Leave open for now in case more comes up.

Todo

Note:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.38%. Comparing base (9f04722) to head (c2c6a95).

:exclamation: Current head c2c6a95 differs from pull request most recent head 8cb2ebd. Consider uploading reports for the commit 8cb2ebd to get more accurate results

Files Patch % Lines
...ttsim/transfers/arbeitsl_geld_2/arbeitsl_geld_2.py 72.72% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #725 +/- ## ========================================== - Coverage 89.42% 89.38% -0.04% ========================================== Files 51 51 Lines 3650 3656 +6 ========================================== + Hits 3264 3268 +4 - Misses 386 388 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MImmesberger commented 4 months ago

This one is finished!

MImmesberger commented 4 months ago

Thanks! Just added tests for the new lines and will merge after tests ran through.