Closed hmgaudecker closed 6 months ago
Attention: Patch coverage is 92.59259%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 89.53%. Comparing base (
62f67df
) to head (a025aa6
).
Files | Patch % | Lines |
---|---|---|
src/_gettsim/interface.py | 90.00% | 1 Missing :warning: |
src/_gettsim/shared.py | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Shouldn't we add support for the
numpy.ndarray[float]
return type here as well? We encountered that in #751.
[edit]
Confused myself: This is wrong, I did in fact catch the location in kindergeld_zur_bedarfsdeckung_m
, the function you change does not use skip_vectorization
.
Great catch!
Oops, I blame it on the time of day :^)
Consider it a testimony to the quality of your work that I blindly thought you'd have to be right :smile:
What problem do you want to solve?
float
bit from typing info likenumpy.ndarray[float]
, so we can use proper return types.np
means our ownnumpy_or_jax
numpy
means numpy proper