iza-institute-of-labor-economics / gettsim

The GErman Taxes and Transfers SIMulator
https://gettsim.readthedocs.io/
GNU Affero General Public License v3.0
56 stars 33 forks source link

Allow array returns when `skip_vectorization` is being used, enforce import convention. #755

Closed hmgaudecker closed 6 months ago

hmgaudecker commented 6 months ago

What problem do you want to solve?

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.53%. Comparing base (62f67df) to head (a025aa6).

Files Patch % Lines
src/_gettsim/interface.py 90.00% 1 Missing :warning:
src/_gettsim/shared.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #755 +/- ## ========================================== + Coverage 89.51% 89.53% +0.01% ========================================== Files 52 52 Lines 3682 3688 +6 ========================================== + Hits 3296 3302 +6 Misses 386 386 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hmgaudecker commented 6 months ago

Shouldn't we add support for the numpy.ndarray[float] return type here as well? We encountered that in #751.

[edit]

Confused myself: This is wrong, I did in fact catch the location in kindergeld_zur_bedarfsdeckung_m, the function you change does not use skip_vectorization.

hmgaudecker commented 6 months ago

Great catch!

MImmesberger commented 6 months ago

Oops, I blame it on the time of day :^)

hmgaudecker commented 6 months ago

Consider it a testimony to the quality of your work that I blindly thought you'd have to be right :smile: