iza-institute-of-labor-economics / gettsim

The GErman Taxes and Transfers SIMulator
https://gettsim.readthedocs.io/
GNU Affero General Public License v3.0
54 stars 32 forks source link

ENH: Consistency check of user-provided `bg_id` #767

Open MImmesberger opened 3 months ago

MImmesberger commented 3 months ago

Check whether the bg_id is sensible if provided by the user.

For example, we can check whether

MImmesberger commented 3 months ago

Quick question regarding this: I planned to check the IDs before the DAG is created. But to test the specification of bg_id I either need to have the outcome of some tax functions available (e.g. kindergeld_anspruch). Or I test the specification via the inputs of p_id_elternteil, p_id_ehepartner, etc. which makes them mandatory inputs. Do you have any preference? @hmgaudecker

hmgaudecker commented 3 months ago

Yes, those p_ids should be mandatory.