iza-institute-of-labor-economics / gettsim

The GErman Taxes and Transfers SIMulator
https://gettsim.readthedocs.io/
GNU Affero General Public License v3.0
54 stars 32 forks source link

Implement Mindesteinkommen for WoG. #772

Closed MImmesberger closed 2 months ago

MImmesberger commented 3 months ago

Closes #592

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.77%. Comparing base (f855be4) to head (b38f14b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #772 +/- ## ========================================== + Coverage 89.63% 89.77% +0.14% ========================================== Files 53 53 Lines 3771 3804 +33 ========================================== + Hits 3380 3415 +35 + Misses 391 389 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MImmesberger commented 2 months ago

On 3 occasions, regression tests fail after switching to Lohnsteuer. Still investigating.

hmgaudecker commented 2 months ago

That may well be! Lohnsteuer should be the correct thing to use, so unless these are "official" test cases, it might not be a big source of worries.

MImmesberger commented 2 months ago

Not sure how official they are. Jakob didn't create test cases that reach back to 2009, right?

hmgaudecker commented 2 months ago

I didn't think he ever did any for Wohngeld. Unless they state a source, you may assume they are regression tests from a time where we did not have Lohnsteuer.

MImmesberger commented 2 months ago

FYI: I removed two input variables because we can compute them now via our usual machinery.

MImmesberger commented 2 months ago

I'll start with a new PR given the requested changes back to hat_kinder and of Lohnsteuer back to Einkommensteuer. Will cherry-pick the commits here.