izar / pytm

A Pythonic framework for threat modeling
Other
891 stars 168 forks source link

Fixed setup.py to install deps #106

Closed archen closed 3 years ago

archen commented 3 years ago

Added the install_requires line needed to install pypi dependencies and opportunistically fixed the usage of summary which isn't recognized by dist/setuptools and used description instead.

ghost commented 3 years ago

DeepCode's analysis on #3dd161 found:

Description Example fixes
Missing close for open, add close or use a with block. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

izar commented 3 years ago

Thanks! Interesting though, the previous version was passing Github CI checks.