Added levels to DFDs

[izar]

This is and idea to be able to add to the same model, for example, infra-structure and application layers, then select on which diagram to produce. This only impacts DFDs, threat elicitation, sequence diagrams and reporting stay the same.

[izar]

Will do!

On Sun, Oct 18, 2020, 13:32 Jan Waś notifications@github.com wrote:

@nineinchnick commented on this pull request.

In pytm/pytm.py https://github.com/izar/pytm/pull/132#discussion_r507190221:

@@ -838,6 +862,9 @@ class Element: doc="Maximum data classification this element can handle.", ) findings = varFindings([])

• levels = [

An important rationale is to be consistent with other attributes. Levels are not special. You could use varData as an example, just with int instead of Data and a regular set at the end instead of Dataset

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/izar/pytm/pull/132#discussion_r507190221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC2BAPPZ477B7OYGFGXK3DSLMRCHANCNFSM4ST2LMFQ .

[izar]

Ah. I think i get what you're saying. Let me rethink it.

On Sun, Oct 18, 2020, 13:26 Jan Waś notifications@github.com wrote:

@nineinchnick commented on this pull request.

In pytm/pytm.py https://github.com/izar/pytm/pull/132#discussion_r507189621:

@@ -404,6 +404,18 @@ def _get_elements_and_boundaries(flows): return (list(elements), list(boundaries))

+def _render_by_level(level):

• Level 0 (default) always renders

• if TM._levels == [0]:

But it's only one level

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/izar/pytm/pull/132#discussion_r507189621, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC2BAILJZZP5B5GI5B22EDSLMQNJANCNFSM4ST2LMFQ .