Add unique Finding ID instead of re-using Threat ID

izar / pytm

A Pythonic framework for threat modeling

Other

876 stars 165 forks source link

Add unique Finding ID instead of re-using Threat ID #154

Closed nozmore closed 3 years ago

nozmore commented 3 years ago

Currently when parsing JSON the Elements contain a list of findings which references only the Threat Id. Since a Threat and given ID can be assigned via a Finding to different components it is not possible to reference a specific finding.

This adds an incremental id to finding starting a 1. which can be used to retrieve the referenced finding.

ghost commented 3 years ago

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that. Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.