izar / pytm

A Pythonic framework for threat modeling
Other
894 stars 169 forks source link

merge graph edges #76

Closed nineinchnick closed 4 years ago

nineinchnick commented 4 years ago

Allow to collapse a request and response dataflow into a single double-arrow edge. This greatly simplifies bigger DFDs and makes them more (actually) readable.

Added 3 new Dataflow attributes:

If only one of those attributes is set, others are filled in automatically, when possible.

When TM.mergeResponses is set, the resulting DFD would look like: dfd

Possibly closes #53

ghost commented 4 years ago

DeepCode's analysis on #b9aa55 found:

:speech_balloon: This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


:relaxed: If you want to provide feedback on our bot, here is how to contact us.

izar commented 4 years ago

Wow, I don't know. To me it makes it harder to read. Let me ask the rest of the team what they think.

nineinchnick commented 4 years ago

The example might be too simple. It works better for large models, especially when there are multiple data flows between one pair of assets. Also note this is optional and not enabled by default.