izaskr / chart_descriptions

0 stars 1 forks source link

Make use consistent: order_last and order_final #51

Closed izaskr closed 4 years ago

emiudeh commented 4 years ago

Can you elaborate? There's currently only use of order_last.

izaskr commented 4 years ago

I found some instances of order_final and fixed them. I opened this issue as a reminder to fix it in other files too.

emiudeh commented 4 years ago

Okay. I think this is done. I wrote a script to go through all files and find instances of "order_final", but none was found. To verify the script works fine, I did same for "order_last" and found 59 instances in the dataset.

izaskr commented 4 years ago

TODO: check for "order_rest" and change into "order_last" or other suitable label.