izhangzhihao / intellij-rainbow-brackets

🌈Rainbow Brackets for IntelliJ based IDEs/Android Studio/HUAWEI DevEco Studio/Fleet
https://plugins.jetbrains.com/plugin/10080-rainbow-brackets
GNU General Public License v3.0
4.44k stars 213 forks source link

Incompatibility with Semantic highlighting #2563

Closed luis-alves closed 1 year ago

luis-alves commented 1 year ago

Your programming languages

Java & Kotlin

Expected Behavior

Should be able to uncheck semantic highlighting and persist this setting after restart.

Current Behavior

When I uncheck the semantic highlighting (SH) with rainbow brackets (RB) enabled, after restarting Intellij the semantic highlighting appears checked again. If I disable RB and uncheck SH it remains unchecked after restarting IntelliJ.

Your Environment

Kotlin: 222-1.7.21-release-272-IJ4167.29

open-collective-bot[bot] commented 1 year ago

Hey @luis-alves :wave:,

Thank you for opening an issue/feature request. We will get back to you as soon as we can.

Please consider support us by buying a license here or donating from OpenCollective https://opencollective.com/intellij-rainbow-brackets.

And we have a special plan for paid users, if you are a paid user, your issue or feature request will have a higher priority.

If you are creating a issue, please make sure you already read the latest change log here.

izhangzhihao commented 1 year ago

same with #2556

luis-alves commented 1 year ago

same with #2556

It's not the same issue

jodyhoonstarr commented 1 year ago

Same issue on webstorm 2022.3. Multiple users reporting similar issues on youtrack

luis-alves commented 1 year ago

Same issue on webstorm 2022.3. Multiple users reporting similar issues on youtrack

Yes this is the same issue

izhangzhihao commented 1 year ago

you can disable Enable rainbow variable to disable the Semantic highlighting option image

Eminanza commented 1 year ago

The problem is when you have "Enable rainbow variables" unchecked because you don't want to use them via the plugin and try to activate them in IntelliJ. Each time you restart IJ, the "semantic highlighting" will revert to unchecked in IntelliJ itself.

There is clearly an interaction between both which should not happen. So for now, I disabled the plugin.

izhangzhihao commented 1 year ago

hi @Eminanza , sorry, I misunderstood your reply, please ignore it. for now, please if you want the "semantic highlighting" works, please make the option "Enable rainbow variables" checked.

izhangzhihao commented 1 year ago

In the next version, a new option added, please enable it if you want to enable Semantic Highlighting but don't want Rainbow Brackets to control it. (please make sure both are checked, and then you could disable or enable it under "Editor -> Color Scheme -> Language Defaults -> Semantic Highlighting"), By the way, to make this option work, you may need to uncheck (and save) and re-check (and save) again the "Semantic Highlighting" option.

And, Merry Christmas.

image
izhangzhihao commented 1 year ago

Please check out the latest release.

duncte123 commented 1 year ago

In the next version, a new option added, please enable it if you want to enable Semantic Highlighting but don't want Rainbow Brackets to control it. (please make sure both are checked, and then you could disable or enable it under "Editor -> Color Scheme -> Language Defaults -> Semantic Highlighting"), By the way, to make this option work, you may need to uncheck (and save) and re-check (and save) again the "Semantic Highlighting" option.

And, Merry Christmas.

image

Leaving "enable rainbow variables" unchecked still disables semantic highlighting if "I will enable semantic highlighting myself" is checked, this should not happen IMO

izhangzhihao commented 1 year ago

hi, you may need a restart and try again.

duncte123 commented 1 year ago

hi, you may need a restart and try again.

Restarting causes rainbow brackets to disable semantic highlighting with this configuration. Tested across PHPStorm, GoLand and IntelliJ ultimate

izhangzhihao commented 1 year ago

can you show any screenshots of your config page?

duncte123 commented 1 year ago

Before restart:

After restart:

izhangzhihao commented 1 year ago

I mean, you should check "Enable rainbow variables" and "I will check..." both, then, this plugin will not change your settings anymore.