Performance: reference local schemas only

iziteq / izi-api-schemes

JSON Schemes for IZI.API validation

2 stars 2 forks source link

Performance: reference local schemas only #5

Closed bartfeenstra closed 9 years ago

bartfeenstra commented 9 years ago

We validate messages a lot and every time multiple schemas are retrieved from Github. This causes a single validation to take between 500ms and 1000ms. All required schema files seem to come from the same repository anyway, so can't the schemas reference other local schema files?

bartfeenstra commented 9 years ago

I'm trying to work on a fix. It seems our JSON validator (https://github.com/justinrainbow/json-schema) contains a bug, though, so it will take a while.

bartfeenstra commented 9 years ago

The PR is located at https://github.com/iziteq/izi-api-schemes/pull/6

vitaly-dukhov commented 9 years ago

Can I close this issue?

bartfeenstra commented 9 years ago

Yes.